PRs ready for review _

aanderse · September 12, 2021, 1:52pm

Package looking for review (module has already been reviewed and approved):

github.com/NixOS/nixpkgs

prowlarr: init at 0.1.1.978

NixOS:master ← jdreaver:prowlarr

opened 03:23PM - 28 Aug 21 UTC

jdreaver

+190 -0

###### Motivation for this change https://github.com/NixOS/nixpkgs/issues/135887 This PR adds a new package and NixOS service for [Prowlarr](https://wiki.servarr.com/prowlarr). This is an indexer similar to `jackett` (which is already in nixpkgs), but is newer and more well-integrated with the *arr ecosystem (e.g. `radarr` and `sonarr`, which are also already in `nixpkgs`). I mostly copied the config from `radarr` and fixed the `prowlarr`-specific bits. In particular, the `update.sh` script had to be modified because the releases are not official releases yet, so we have to specify the version we want to use. **This is my first significant `nixpkgs` PR.** I've updated the versions of packages before, but I've never added a new service from scratch. I would think anyone who is a maintainer for `radarr` could/should review this. I'm also happy to add myself as a maintainer for this package, but I'm not sure what the protocol on that is. I used this `nixpkgs` fork and enabled `prowlarr` in my home server's NixOS config, and it worked flawlessly, so this has basically been tested end-to-end. ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [x] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

cab · September 14, 2021, 12:41pm

github.com/NixOS/nixpkgs

super-slicer.stable: 2.3.56.8 -> 2.3.56.9

NixOS:master ← cab404:super-slicer-2.3.56.9

opened 06:19AM - 07 Sep 21 UTC

cab404

+16 -5

also, super-slicer.staging: init at 2.3.57.0  ###### Motivation for this change ###### Things done - Built on platform(s) - [X] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

zakame · September 14, 2021, 2:48pm

Hi, I’m looking for reviews for

github.com/NixOS/nixpkgs

taoup: init at 1.1.14

NixOS:master ← zakame:contrib/ruby-taoup

opened 05:45AM - 05 Sep 21 UTC

zakame

+137 -0

###### Motivation for this change https://github.com/globalcitizen/taoup is a… `fortune`-like tool that tells some words of wisdom from _The Art of Unix Programming_ and other sources. Some patches are included to simplify the `taoup-fortune` example script (which tries to produce a cache directory at first run - we instead create and populate this at build time,) and `taoup` itself (which tries to test for `tput` - avoid that and just depend on `ncurses` to provide that instead.) I suspect some improvements can be made still at the `postPatch` and `installPhase` steps - I'd love to hear anyone's guidance on this :pray: Thanks! ###### Things done - Built on platform(s) - [X] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [x] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [X] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [X] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

thanks!

roberth · September 16, 2021, 5:34pm

Test automation for fetchers!

They used to be tricky to hack on because they don’t re-run after completing once. With this technique, we can have tests as usual.

github.com/NixOS/nixpkgs

Fetcher testing

NixOS:master ← hercules-ci:fetcher-testing

opened 08:34AM - 28 Aug 21 UTC

roberth

+65 -4

###### Motivation for this change Make maintenance easier on the fetchers and… avoid problems. The `packageTests` attribute will serve two purposes: - for ofborg: allow it to build tests in a __functor attrset like `fetchgit` - for hydra, potentially, build the package tests. Enabling these is not part of this PR. Closes #133739 Refs #128749 #135881 or really all of [topic: fetch](https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen++label%3A%226.topic%3A+fetch%22+) ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

nappa · September 16, 2021, 9:09pm

Can someone take a look at this, that has been ignored for a couple of weeks (maintainer is not responding, and the same happened with #134390, but that one was merged).

It should be merged, because the complicated license doesn’t allow free distribution of that code.
And I need it to be merged so I can send my other PRs to fix the build on darwin and fix/enable the Python interface.

I can take over maintenance, since I’ve put a lot of work to fix the package (including merged #134390 and #134393, and my upcoming PRs).

github.com/NixOS/nixpkgs

shogun: remove non-distributable SVMlight code

NixOS:master ← smancill:shogun-remove-svmlight

opened 12:11AM - 03 Sep 21 UTC

smancill

+96 -2

###### Motivation for this change Shogun is using non-distributable SVMLight …code that should be removed from the package. SVMLight uses a [non-standard license](https://github.com/shogun-toolbox/shogun/blob/shogun_6.1.4/doc/license/LICENSE_SVMlight.md) that doesn't allow distribution without the author's permission: > The software must not be modified and distributed without prior permission of the author. ---- I am working on a PR to fix Shogun on Darwin and add it as a Python module, and that's why I found that currently it is built with SVMLight, which should not be packaged on a distribution. Upstream's own Debian package, Fedora, Conda, they all remove it. I think this had to be its own PR, and maybe backported to 21.05. ###### Things done Remove all SVMLight code when building the binary package. Use upstream's own script to do it (which they use to create and distribute their own Debian package), with a few fixes (see added patch file). - Built on platform(s) - [X] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin (currently broken on Darwin, I will send the fix in a new PR) - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

illustris · September 18, 2021, 7:26am

Can someone review these PRs open for a couple of weeks?

github.com/NixOS/nixpkgs

octoprint.python.pkgs.octolapse: init at 0.4.1

NixOS:master ← j0hax:octolapse

opened 09:56PM - 02 Sep 21 UTC

j0hax

+48 -0

###### Motivation for this change Package the popular Octolapse plugin along with an additional python dependency ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

github.com/NixOS/nixpkgs

octoprint.python.pkgs.ender3v2tempfix: init at unstable-2021-04-27

NixOS:master ← illustris:octoprint

opened 04:23AM - 01 Sep 21 UTC

illustris

+19 -0

###### Motivation for this change - using octoprint with certain Creality printers requires the temperature reporting fix plugin - octolapse is a popular plugin for octoprint ###### Things done - Built on platform(s) - [x] x86_64-linux - [x] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

jasper · September 25, 2021, 10:59am

This change of the resilio-sync module has been sitting for a couple of months. It introduces the option of managing resilio sync secrets using secret files, so those secrets don’t need to end up in the nix store. I’d super appreciate a review!

github.com/NixOS/nixpkgs

nixos/resilio: support secret files

NixOS:master ← jwoudenberg:master

opened 02:46PM - 05 Jun 21 UTC

jwoudenberg

+41 -7

###### Motivation for this change The Resilio nixos module supports declarati…vely configuring Resilio using the `sharedFolders` attribute. Secrets for shared folders can be passed using the `secret` attribute, with the downside that these secrets will end up in the nix store. The goal of this change is to allow shared folder secrets to be specified without requiring they be put in the nix store, without breaking backwards compatibility with existing Resilio module configurations. It follows the approach outlined in the issue below, for upstream packages that do not provide password file support out of the box: https://github.com/NixOS/nixpkgs/issues/24288 The change also modifies documentation to encourage the use of the new secret file support, because it seems like the safer default to me, but I don't feel strongly about that and am happy to change that back. ###### Things done - [x] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [x] NixOS - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes](./CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [x] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

romildo · September 26, 2021, 10:13pm

github.com/NixOS/nixpkgs

lxqt.lxqt-config: gsettings is a runtime dependence

NixOS:master ← romildo:fix.lxqt-config

opened 12:16PM - 17 Sep 21 UTC

romildo

+8 -0

###### Motivation for this change The binary `gsettings` is a runtime dependence. Hardcode its absolute path so that it can be found for sure. ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

sikmir · October 3, 2021, 7:59am

github.com/NixOS/nixpkgs

mapserver: init at 7.6.4

NixOS:master ← sikmir:mapserver

opened 04:47AM - 15 Sep 21 UTC

sikmir

+123 -0

###### Motivation for this change * [MapServer](https://www.mapserver.org) is a…n Open Source platform for publishing spatial data and interactive mapping applications to the web. * [MapCache](https://www.mapserver.org/mapcache/) is a server that implements tile caching to speed up access to WMS layers. ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [x] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

Poscat · October 11, 2021, 8:22am

github.com/NixOS/nixpkgs

unbound: enable more features

NixOS:master ← poscat0x04:unbound-ecs

opened 12:39PM - 20 Sep 21 UTC

poscat0x04

+30 -0

###### Motivation for this change Currently unbound in nixpkgs has a lot of not…-enabled features. Some of them are quite useful. ###### Things done This pull request adds options for these features: - EDNS Client Subnet - DNSCrypt - DNSTAP - TCP Fast Open - Cache DB module - Redis backend for the Cache DB module (also is there a more elegant way of achieving the same goal as [these lines](https://github.com/poscat0x04/nixpkgs/blob/unbound-ecs/pkgs/tools/networking/unbound/default.nix#L123-L125)?) --- - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

mkg20001 · October 11, 2021, 3:29pm

github.com/NixOS/nixpkgs

Add pam_tty_audit and corresponding option in pam module

NixOS:staging ← mkg20001:pam-audit

opened 12:44PM - 13 Sep 21 UTC

mkg20001

+48 -2

###### Motivation for this change Make this pam module usable ###### Things done - Built on platform(s) - [ ] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md). This allows building the pam_tty_audit module, among others

kfollesdal · October 13, 2021, 3:08pm

Working on adding python package typical to nixpkgs. It depends on package future-typing. Have a working derivation for it, but must disable one test file. The test fails because it use an encoder that future-typing install. But it seems that it is not available when tests runs. Any help to get the last test file to work?

It is the header # -*- coding: future_typing -*- in the following file that is making problems: https://github.com/PrettyWood/future-typing/blob/4bb6bb2bdfbc92676f86e9cd75193b5cae8d121e/tests/test_future_typing.py

github.com/NixOS/nixpkgs

Review by kfollesdal in pythonPackages.typical: init at 2.7.9

NixOS:master ← kfollesdal:kfollesdal/typical

How can we get the tests in tests/test_future_typing.py to work? It fails s…ince it does not find the encoder `future_typing` that is installed by `future-typing`. So it seems that the encoder is not available in the test environment. The test file tests/test_future_typing.py use the encoder by the header with `# -*- coding: future_typing -*-` but the test fails with error `SyntaxError: unknown encoding: future_typing`. How can we fix this? The test file that fails is https://github.com/PrettyWood/future-typing/blob/main/tests/test_future_typing.py

liff · October 13, 2021, 8:03pm

Here’s a small quality of life improvement for Gradle users. Inconveniently large rebuild for what it is but suppose that cannot be helped.

github.com/NixOS/nixpkgs

gradle: Add ncurses dependencies on Linux

NixOS:staging ← liff:gradle-native

opened 07:57PM - 30 Aug 21 UTC

liff

+16 -9

###### Motivation for this change If ncurses is available Gradle can use it to prettify its output and show progress during task execution. The fixup step patches the bundled native libraries with libstdc++ but not with ncurses, which means that Gradle will always use the (non-pretty) fallback native platform libraries. Patching the native platform libraries with ncurses5 and ncurses6 dependencies fixes the issue. For some reason both ncurses5 and ncurses6 are required. Gradle will refuse to start if, for example, the ncurses5 native platform jar is missing. ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

bobvanderlinden · October 15, 2021, 8:20am

github.com/NixOS/nixpkgs

nixos/docker: add daemon.settings option

NixOS:master ← bobvanderlinden:docker-daemon-config

opened 06:22PM - 13 Oct 21 UTC

bobvanderlinden

+40 -7

###### Motivation for this change Docker has quite a few configuration option…s. You can see them here: https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-configuration-file Some of these can be set using command-line options and thus using `virtualisation.docker.extraOptions`, but some of them are only available using the JSON configuration file. One example is `log-opts`. In addition, serializing `types.anything` to JSON results in a nicer way to configure docker. For comparison: ``` extraOptions = "--ipv6 --fixed-cidr-v6 fd00::/80"; ``` with: ``` daemon.settings = { ipv6 = true; "fixed-cidr-v6" = "fd00::/80"; }; ``` This also allows the use of the mk* functions in order to modularize the configuration better. Do note that anyone who has created `/etc/docker/daemon.conf` in the past to configure Docker ad-hoc must now migrate this configuration to NixOS's configuration. I have added a incompatibility note in the release notes. ###### Things done I cherry-picked this commit to an older revision that I was able to build. I ran the docker tests: ``` nix-build nixos/tests/docker.nix ``` I confgured my system using: ``` virtualisation.docker = { enable = true; daemon.settings = { ipv6 = true; "fixed-cidr-v6" = "fd00::/80"; }; }; ``` I switched my system: ``` nix flake update --override-input nixpkgs $HOME/projects/nixpkgs && sudo nixos-rebuild --flake . switch ``` After that, the systemd service looks as follows: ``` $ systemctl is-active docker active $ systemctl cat docker ... ExecStart=/nix/store/5m6801fx87daw9cd63dkii7qv998647s-docker-20.10.9/bin/dockerd \ --config-file=/nix/store/pi1kc96nflwhaxzzfx295ds93j2fsh2p-daemon.json \ ``` The config file looks as follows: ``` $ cat /nix/store/pi1kc96nflwhaxzzfx295ds93j2fsh2p-daemon.json { "fixed-cidr-v6": "fd00::/80", "group": "docker", "hosts": [ "fd://" ], "ipv6": true, "live-restore": true, "log-driver": "journald" } ``` - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

Poscat · October 15, 2021, 11:49am

Not my own PR, but It would nonetheless be great if someone can get this merged.

github.com/NixOS/nixpkgs

nixos/dovecot: More sieve options and precompiling of scripts

NixOS:master ← griff:dovecot-precompile

opened 11:28AM - 25 Feb 18 UTC

griff

+498 -47

##### Motivation for this change This PR does 4 different things in the 3 com…mit: * Adds test of sieve scripts to `nixos/tests/dovecot.nix` * Patches dovecot_pigeonhole with this change dovecot/pigeonhole#4 * Adds builder to precompile sieve scripts * Adds more options relating to sieve scripts to dovecot2 module ###### test of sieve scripts Before making changes to how sieve scripts were handled I thought it best that the dovecot test included some testing of the sieve script functionality. ###### Patching dovecot_pigeonhole and builder to precompile scripts One of the changes I wanted to make was to precompile sieve scripts as part of a Nix derivation. But to do that dovecot_pigeonhole needs to be changed since when source and compiled script have same mtime it thinks that the compiled script is out of date. I have tried to upstream that change with dovecot/pigeonhole#4 but it is as of yet not merged. The builder does its compilation in the install phase because the compiled `.svbin` files contain a reference to the full path of the source `.sieve` file and so the source needs to be in `$out` when doing the compile. ###### Sieve related options in the dovecot2 module When precompiling sieve scripts the compiler needs a dovecot configuration that defines `sieve_plugins`, `sieve_extensions` and `sieve_global_extensions` to know which extensions and plugin functionality to allow but you can’t just use the dovecot2 config file directly because that would create a dependency cycle. So to better support precompilation I have added explicit options for these 3 things to the dovecot2 module so that I can reuse their values when precompiling. The `sieveScripts` option followed very closely how dovecot configures global scripts and was a direct mapping from attribute name to `sieve_${attribute name}` which has some problems. E.g. if you defined `sieveScripts.after2` without defining `sieveScripts.after` your script would never be called. It also wasn’t totally clear without reading the dovecot documentation what scripts you could define. So I have added explicit options `sieve.beforeScripts`, `sieve.defaultScript`, `sieve.afterScripts` and `sieve.discardScript` for each of the scripts you can define with `beforeScripts` and `afterScripts` being lists of paths that are automatically translated to the correct numbered dovecot configuration and with the added bonus that multiple definitions of the option are merged into one list. I have also included functionality so that existing configurations that use the `sieveScripts` option continue to work as before but now with a warning pointing to the new options. The other place were you might use global sieve scripts and so would like to precompile the scripts is when using the `imapsieve` plugin. Before there were no options for this so I have added options for enabling and configuring `imapsieve` with support for automatic precompilation of scripts. ##### Things done - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS) - Built on platform(s) - [X] NixOS - [ ] macOS - [ ] other Linux distributions - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"` - [X] Tested execution of all binary files (usually in `./result/bin/`) - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md). ---

efx · October 15, 2021, 1:26pm

github.com/NixOS/nixpkgs

docs: improve Rust language guide

NixOS:master ←

opened 08:25PM - 11 Oct 21 UTC

ghost

+82 -51

###### Motivation for this change This stems from a discussion [here](https://discourse.nixos.org/t/what-rust-overlay-do-you-use-and-why-advice-appreciated/15412) ###### Things done - Built on platform(s) - [ ] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

romildo · October 17, 2021, 1:47pm

github.com/NixOS/nixpkgs

enlightenment.terminology: 1.9.0 -> 1.10.0

NixOS:master ← romildo:upd.terminology

opened 01:40PM - 13 Oct 21 UTC

romildo

+6 -6

###### Motivation for this change Update to version [1.10.0](https://www.enlightenment.org/news/2021-10-03-terminology-1.10.0) ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

fabianh · October 18, 2021, 4:59pm

git-fast-export: 200213 → 210917 by fabianhjr · Pull Request #142046 · NixOS/nixpkgs · GitHub for the removal of mercurial_4 ( mercurial_4: remove by fabianhjr · Pull Request #142102 · NixOS/nixpkgs · GitHub )

superherointj · October 20, 2021, 6:28pm

github.com/NixOS/nixpkgs

pythonPackages: removes Python2 broken packages

NixOS:master ← superherointj:python2-remove-broken-packages

opened 07:20PM - 15 Oct 21 UTC

superherointj

+134 -4772

PR is ready for review. -- Removes all **broken** Python 2 packages. 114 …of 265. 43% of packages broken. If something important breaks, we can always restore it. :-) List of [broken](https://gist.github.com/superherointj/e479e2b3333273b629217444969f6da8) packages ``` appleseed arrow ase bitbucket_api bitbucket-cli blivet browsermob-proxy cairocffi cairosvg cherrypi cliapp cmdtest coilmq construct django_evolution docker-py dulwich flask flask_ldap_login flit flit-core fontforge gdcm geant4 google-api-python-client gdrivefs hg-git hgsvn imagecodecs-lite imbalanced-learn ipykernel ipython jsonrpclib jupyter_client jupyter_console koji kicad larch Lasagne ldaptor libcloud libgpiod libvirt lirc lpod lsi mapsplotlib marionette-harness marionette_driver matplotlib mercurial meson mlt moinmoin monosat mozprofile mozrunner mozsvc mwlib mwlib-rl nbformat nevow nixpart0 nixpart notebook nxt-python openwrt-luci-rpc pandas #pillow <- Delayed removal postorius praw privacyidea-ldap-proxy pycangjie pycarddav pyexiv2 pykickstart python-otr pythonIRClib pythonmagick pyutil qserve remotecv rivet robotframework-ride runsnakerun rpm rpkg scikit-learn scipy seaborn serversyncstorage sequoia sipsimple smartdc snug sphinx squaremap subliminal suds tarman thumbor tokenizers tokenize-rt tokenserver ttystatus wptserve werkzeug wxPython wxPython30 <- Removal delayed vcrpy xenomapper yt zeek zbase32 zfec ```

illustris · October 20, 2021, 9:05pm

github.com/NixOS/nixpkgs

nixos/hadoop: package rewrite and module improvements

NixOS:master ← illustris:hadoop

opened 10:05PM - 09 Oct 21 UTC

illustris

+403 -240

##### Motivation for this change The current system of building hadoop creates a monolithic fixed-output "build-deps" derivation by running maven in a loop. This makes updating the packages and using custom builds of hadoop much more difficult. It also forces expensive full rebuilds for minor changes. Most of the difficulties in building the package from source are because of maven's unusual way of doing things, such as returning different checksums for the same files, or downloading dynamically linked binaries at build time. The new package can directly accept upstream builds from apache, or binaries from your own custom builds. The HDFS and YARN modules in their present state require too much manual configuration to spin up a cluster. The changes in this PR adds many sane defaults that make it possible to start a cluster with very little manual configuration. See `nixos/tests/hadoop/hadoop.nix` for an example. The existing tests for HDFS and YARN are simply checking whether the namenode, datanode, resourcemanager and nodemanager services start up and expose their web UIs. This is not enough to check if the services are able to communicate, store data and run workloads. The newly added test will test the following: - Does the HDFS cluster exit safemode after startup? - Does the YARN resourcemanager register the nodemanager? - Does a simple mapreduce job using YARN for compute and HDFS for storage succeed? ##### Things done ###### Package: - Update to latest releases as per https://hadoop.apache.org/releases.html - Point the `hadoop` package to the latest 3.x release - Add `hadoop2` pointing to the latest hadoop 2.x release - Replace maven for-loop fixed output builds with binary releases - Add more easily accessible options to selectively enable native libraries - set defaults for HADOOP_HOME and HADOOP_CONF_DIR with makeWrapper ###### Module: - Remove `HADOOP_HOME` from service config as it is now correctly set by the package - Set default restart policy for all services to `always` - Add an option to add additional files to `HADOOP_CONF_DIR` - Add hadoop CLI tools to systemPackages when any hadoop service is enabled - Add restartIfChanged option - Add support for LinuxContainerExecutor, make it the default executor type - Add firewall defaults and options - Generate container-executor.cfg from options ##### Tests - Add cluster test for HDFS and YARN - Add unified test for HDFS+YARN+mapreduce ##### Todo - Add documentation ##### Future work In its current state, the module doesn't make it easy to spin up an [HA HDFS cluster with QJM](https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/HDFSHighAvailabilityWithQJM.html). Usually this would require a series of manual steps to initialize the cluster. In subsequent PRs I'll try to make a 1-click deployment of a production-ready HA hadoop cluster possible. While building from source is very inconvenient with nix's currently limited support for maven, it would be nice to provide the option to build hadoop from source eventually. - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

A few minor changes are pending, but I’d appreciate a review at this stage.