I’ve updated my Pi-hole PR to address previous comments, and rebased it on master while tidying up the commits. If anyone has the time another review would be appreciated!
NixOS:master ← williamvds:add_pihole
opened 09:41PM - 05 Apr 23 UTC
###### Description of changes
[Pihole](https://pi-hole.net) describes itself … as "A black hole for Internet advertisements".
It's a suite for running and administrating a DNS sinkhole, which filters queries and caches their results, primarily to block advertisements and other undesirable traffic originating from the LAN.
Built on dnsmasq, the DNS server (called pihole-FTL) can also be used as a DHCP server to automatically configure LAN clients to use pihole's DNS.
The pihole-ftl package is based on #108055 by @JamieMagee (itself based on the work of @nuxeh). The remaining work was done mostly from scratch.
This PR resolves the package request issue #61617.
This PR includes packages for:
* [pihole-ftl](https://github.com/pi-hole/FTL): The DNS server, forked from dnsmasq
* [pihole-adminlte:](https://github.com/pi-hole/AdminLTE) A web server which shows statistics, logs, and allows more advanced configuration of pihole-FTL
* [pihole](https://github.com/pi-hole/pi-hole): A collection of scripts for managing pihole-FTL
The last one needs the heaviest modifications, particularly to excise the reinstallation/upgrade functionality, which is not needed on NixOS.
NixOS modules are provided for pihole-ftl and pihole-adminlte.
pihole-ftl's module is largely a wrapper around the existing dnsmasq one, since they are mostly compatible applications. Some additional options are provided for automatically setting the adlists for pihole to download and apply.
pihole-adminlte's module is rather minimal, with some cosmetic options for temperature units and the web theme.
To do:
- [x] Documentation
- [ ] NixOS tests for AdminLTE and pihole-FTL?
- [ ] Diagnose/resolve a bug where AdminLTE gets "attempt to write to a readonly database" errors until it is restarted.
- This only happens on the first run, when AdminLTE starts before `/etc/pihole/gravity.db` is created
- Could be systemd hardening?
###### Things done
- Built on platform(s)
- [x] x86_64-linux
- [x] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
- [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [x] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [23.05 Release Notes (or backporting 22.11 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2305-release-notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [x] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
<!--
To help with the large amounts of pull requests, we would appreciate your
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->
OPNA2608
September 14, 2023, 5:23pm
2651
https://github.com/NixOS/nixpkgs/pull/243238
NixOS:master ← OPNA2608:init/lomiri/ayatana-messages
opened 01:33PM - 14 Jul 23 UTC
###### Description of changes
Working towards #99090.
[Ayatana Indicators]… (https://ayatanaindicators.github.io/) are a continuation of Canonical's [Application Indicators](https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationIndicators). Lomiri makes use of them for its top bar system: without at least [ayatana-indicator-session](https://github.com/AyatanaIndicators/ayatana-indicator-session), you won't be able to exit the session as there will be no way to trigger the dialogue :stuck_out_tongue:.
This PR:
- Inits `ayatana-indicator-messages` as a start.
- Inits a NixOS module for having `ayatana-indicators.target` bring up a list of desired indicators. I'll happily accept better solutions for this.
- The individual indicator services normally bind to the target via `WantedBy`, but we don't install (user) services on NixOS so one of the sides from this interaction needs to be get an explicit `Wants` (to the best of my knowledge)
- Rewriting the target all the services bind to seemed easier than rewriting all the services
- A custom `passthru.ayatana-indicators = [ "thingy" ]` attribute is expected to be present in all requested indicator package, listing the indicator services they provide. There's no individual package with multiple services that I'm aware of, but I see no reason to disallow this in practice.
- Adds a VM test that makes sure the various indicators we're going to add work & keep working.
---
Some future indicators will come with optional Lomiri-specific support. I'll enable this when possible, and try to keep an eye on closure size increase so future non-Lomiri uses won't be too affected. See #262118 for a first push for that + initial closure considerations there.
The test is using MATE because it's one of the DEs with theoretical support for them, and because the target is supposed to depend on a graphical session, but its support is not really being used. [`mate.mate-indicator-applet` would first have to be patched to use Ayatana indicators and find new-style ones](https://github.com/NixOS/nixpkgs/pull/262172), it would require (graphical?) panel configuration to load the indicator applet, and it doesn't seem to support/show some indicators (only 1/3 of the ones I tested showed up, but maybe I just picked some not-useful ones). Maybe it can be rewritten to use Lomiri later on, which has none of those issues, but it's somewhat-secondry to me when the entire rendering part of the interplay is really DE-specific.
###### Things done
- Built on platform(s)
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [x] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md))
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
<!--
To help with the large amounts of pull requests, we would appreciate your
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->
https://github.com/NixOS/nixpkgs/pull/244138
panicgh
September 14, 2023, 10:06pm
2654
NixOS:master ← panicgh:foonathan-memory
opened 09:21AM - 11 Sep 23 UTC
## Description of changes
https://github.com/foonathan/memory
STL compatib… le C++ memory allocator library.
This package in other distros: https://repology.org/project/foonathan-memory/versions
## Things done
- Built on platform(s)
- [X] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [X] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md))
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
https://github.com/NixOS/nixpkgs/pull/254630
Yarny
September 15, 2023, 2:35pm
2655
andersk
September 15, 2023, 7:36pm
2656
https://github.com/NixOS/nixpkgs/pull/249410
NixOS:master ← andersk:zulip
opened 07:28AM - 14 Sep 23 UTC
## Description of changes
Update the Zulip desktop app from 5.10.0 to 5.10.2.…
https://github.com/zulip/zulip-desktop/releases/v5.10.1
https://github.com/zulip/zulip-desktop/releases/v5.10.2
https://github.com/zulip/zulip-desktop/compare/v5.10.0...v5.10.2
Includes #237447 for Wayland support.
## Things done
- Built on platform(s)
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [x] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md))
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
<!--
To help with the large amounts of pull requests, we would appreciate your
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->
mdarocha
September 15, 2023, 9:24pm
2657
p-rintz
September 17, 2023, 2:04am
2660
misuzu
September 18, 2023, 7:25am
2666
This fixes numpy on i686-linux/armv7l-linux
NixOS:staging ← misuzu:numpy-32-bit-fix
opened 07:35AM - 28 Aug 23 UTC
## Description of changes
Closes: https://github.com/NixOS/nixpkgs/issues/25151… 4
<!--
For package updates please link to a changelog or describe changes, this helps your fellow maintainers discover breaking updates.
For new packages please briefly describe the package or provide a link to its homepage.
-->
## Things done
- Built on platform(s)
- [X] x86_64-linux
- [X] i686-linux
- [X] armv7l-linux (native)
- [X] aarch64-linux
- [X] x86_64-darwin
- [X] aarch64-darwin
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [ ] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md))
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
<!--
To help with the large amounts of pull requests, we would appreciate your
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->